clintropolis commented on code in PR #15058:
URL: https://github.com/apache/druid/pull/15058#discussion_r1346751625


##########
processing/src/main/java/org/apache/druid/query/filter/ValueMatcher.java:
##########
@@ -31,6 +31,16 @@
  */
 public interface ValueMatcher extends HotLoopCallee
 {
+  /**
+   * Returns true if the current row matches the condition.
+   *
+   * @param includeUnknown mapping for Druid native two state logic system 
into SQL three-state logic system. If set
+   *                       to true, this method should also return true if the 
result is 'unknown' to be a match, such
+   *                       as from the input being null valued. Used primarily 
to allow
+   *                       {@link org.apache.druid.segment.filter.NotFilter} 
to invert a match in an SQL compliant

Review Comment:
   lies



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to