clintropolis commented on code in PR #15058:
URL: https://github.com/apache/druid/pull/15058#discussion_r1346762145
##########
processing/src/main/java/org/apache/druid/segment/filter/ColumnComparisonFilter.java:
##########
@@ -79,14 +79,16 @@ public ValueMatcher makeMatcher(ColumnSelectorFactory
factory)
public static ValueMatcher makeValueMatcher(final List<Supplier<String[]>>
valueGetters)
{
if (valueGetters.isEmpty()) {
- return BooleanValueMatcher.of(true);
+ return ValueMatchers.allTrue();
}
return new ValueMatcher()
{
@Override
- public boolean matches()
+ public boolean matches(boolean includeUnknown)
{
+ // todo (clint): what to do about includeUnknown
Review Comment:
cool, forgot about this todo, will add javadoc to this filter to call out
this behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
