clintropolis commented on code in PR #15058:
URL: https://github.com/apache/druid/pull/15058#discussion_r1346756579
##########
processing/src/main/java/org/apache/druid/segment/DimensionSelector.java:
##########
@@ -186,6 +187,9 @@ static DimensionSelector multiConstant(@Nullable final
List<String> values)
// does not report value cardinality, but otherwise behaves identically
when used for grouping or selecting to a
// normal multi-value dimension selector (getObject on a row with a
single value returns the object instead of
// the list)
+ if (values.get(0) == null) {
+ return NullDimensionSelectorHolder.NULL_DIMENSION_SELECTOR;
+ }
Review Comment:
oops i think it is not, i think i must have confused myself between the
constant method which diverts nulls to the nil selector and the
`ConstantDimensionSelector` which guards against nulls and explodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
