clintropolis commented on code in PR #15058:
URL: https://github.com/apache/druid/pull/15058#discussion_r1346763152
##########
processing/src/main/java/org/apache/druid/segment/vector/FilteredVectorOffset.java:
##########
@@ -129,7 +129,8 @@ private void advanceWhileVectorIsEmptyAndPopulateOffsets()
return;
}
- final ReadableVectorMatch match =
filterMatcher.match(VectorMatch.allTrue(baseOffset.getCurrentVectorSize()));
+ final ReadableVectorMatch match =
filterMatcher.match(VectorMatch.allTrue(baseOffset.getCurrentVectorSize()),
Review Comment:
this is the main reason i hate using intellij to add parameters with default
values for me using the refactor dialog thingo... on the one hand i'm lazy and
its nice it can fill the falses in everywhere, but it always mangles everything
so idk if i really come out ahead...
##########
processing/src/main/java/org/apache/druid/segment/filter/NotFilter.java:
##########
@@ -42,6 +44,18 @@
import java.util.Set;
/**
+ * Nice filter you have there... NOT!
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
