clintropolis commented on code in PR #15058:
URL: https://github.com/apache/druid/pull/15058#discussion_r1346759343
##########
processing/src/main/java/org/apache/druid/segment/StringDimensionIndexer.java:
##########
@@ -380,38 +384,70 @@ public void inspectRuntimeShape(RuntimeShapeInspector
inspector)
}
};
} else {
- return BooleanValueMatcher.of(false);
+ return new ValueMatcher()
+ {
+ @Override
+ public boolean matches(boolean includeUnknown)
+ {
+ if (includeUnknown) {
+ IndexedInts row = getRow();
+ if (row.size() == 0) {
+ return true;
+ }
+ //noinspection SSBasedInspection
Review Comment:
cool, i forgot where this was defined and couldn't remember why it warned
against it, but that makes sense. looks like a few other places that can also
be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
