SEZ9 commented on issue #11007: URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5564189117
@Nikk8091 following up on the DingTalk claim: it is recorded for you as a connector-dingtalk-only slice, and there is still no other active PR covering DingTalk validation in this thread. To recap the agreed scope so the PR review goes smoothly: - Keep `url` and `secret` required in `DingTalkSinkFactory.optionRule()` and express the blank-value rule for both through the existing declarative notBlank condition, as you proposed. - Replace the placeholder factory test with focused factory-validation coverage for valid, empty, and whitespace-only values of both options. - Preserve option names, all existing nonblank configurations, and runtime network behavior. Do not add remote DingTalk checks, modify the writer, or touch anything outside connector-dingtalk. Remaining ask: please link the focused PR here once it is open so it can be tracked against this claim. If anything in the current dev implementation turns out to differ from what you described (for example, how the placeholder test is wired), mention it in the PR description rather than expanding the change set. Thanks! <!-- streview-comment:853 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
