SEZ9 commented on PR #11512: URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-5788414617
Thanks for the follow-up commits since `dfabd777e98` (`d4cd62c3b69`, `4e7d62d176c`, `5e9b506a74a`, and the current head `0b38a3d9b7c2`, plus the dev-sync merge `732cdd06fca`). I see the F1-F8 mapping was already requested on this thread and the latest review reports verifying this round item by item against `0b38a3d9b7c2`, so I won't ask for that again. One small thing to close out on my side: if any of the earlier points (F1 bounded `activeSplits`, F2 no secrets in position payloads, F3 enum encoding by name, F4/F5/F6 doc alignment, F7 count invariants, F8 immutability wording) were intentionally deferred rather than addressed at this head, could you note which ones so we can track them in a follow-up? If everything is covered, no further action needed from me. <!-- streview-comment:1256 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
