SEZ9 commented on PR #11512:
URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-5754694859
Since `d8cb0cbb7d3` the PR has picked up one dev-sync merge (`d552a4e2b6e`,
no PR-owned change) and one test-only commit, `270a40b7f98` ("Check every
negative progress count independently"), so the current head is
`270a40b7f98bb43270eff0e240e38c896303d298`.
The new independent negative-count assertions line up with the earlier
count-invariant point on `CdcEnumeratorProgressReport`, thanks for adding them.
The API model and wire codec look in good shape at this head.
What I could not yet tell from the current commits is the status of the
earlier documentation points in `docs/en/developer/cdc-progress.md` and the
related Javadoc:
- stating that connector-native position payloads must not carry credentials
or connection secrets
- aligning the runtime collection description with the registration-based
enumerator report path
- listing which connectors currently implement `CdcProgressProvider`
- narrowing the `CdcProgressLifecycle.SNAPSHOT` Javadoc so it no longer
includes enumerator-owned discovery/assignment
Could you note which of these are already addressed at the current head and
which you would prefer to handle in a follow-up? Happy to take another full
look once I know where they stand.
<!-- streview-comment:1203 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
