DanielLeens commented on PR #12592:
URL: https://github.com/apache/seatunnel/pull/12592#issuecomment-6338433466

   Thanks @hutiefang76. The explicit alias-detection contract and the linked 
upgrade note answer the outstanding clarification, and keeping the 
cache/lifecycle and Calendar work as named follow-ups is a reasonable scope 
decision. There is no new commit to review in this exchange. My source-level 
conclusion stays clear.
   
   One correction to my queued-run note: Build has now completed with failure. 
I inspected the JDK 11 unit-test and edge-agent logs; both stop on the archived 
LLM fixture, 
`LLMBooleanOutputTest.readsLegacyFactoryWrapperWithValidationDisabled` 
(`InvalidClassException` on `AbstractMultiCatalogTransform`). This is not an 
executed DuckDB assertion. Proposed upstream fix #12938 is still open, and 
latest dev has not incorporated it, so syncing today alone will not clear this 
failure. Once it lands, sync and rerun the affected failed jobs. A successful 
required Build and write-capable maintainer approval are still needed.
   
   Current status evidence: head `743ed3a0640f3d4bf8a7da5caf087fa8c7d36100`, 
base `dev`, compare `diverged` (ahead 15, behind 10), mergeable state `blocked`.
   
   CI references: [current Build 
check](https://github.com/apache/seatunnel/runs/118806610233), [Run / 
edge-agent-it (11, 
ubuntu-latest)](https://github.com/hutiefang76/seatunnel/actions/runs/39440355528/job/118822707848),
 [Run / unit-test (11, 
ubuntu-latest)](https://github.com/hutiefang76/seatunnel/actions/runs/39440355528/job/118822707276).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to