DanielLeens commented on PR #12710:
URL: https://github.com/apache/seatunnel/pull/12710#issuecomment-6359843764
Thanks @SEZ9 for the check on `016f3d4c`, and thanks @ricky2129 for keeping
the branch current. A quick status update, because the head has moved since my
note above: it is now `f7ee365ced` (another `Merge branch 'dev'`, no code of
yours). I compared the 15 files this PR owns between `016f3d4c` and
`f7ee365ced` and nothing in them changed, so my source-level conclusion is
unchanged (static reading only, nothing executed locally). The apache-side
`Build` for `f7ee365ced` is now green, which closes the CI gate I raised in my
previous comment; GitHub shows the PR as mergeable (`CLEAN`).
One item is still open, and it is the same one @SEZ9 and I agreed on: the
`SeaTunnelServer.shutdown` terminate-flag question stays out of this PR, but I
could not find a follow-up issue linked from the description (the description
does not mention one, and a search of the open and closed issues did not turn
up one either). @ricky2129, could you please open a small issue that states the
question ("with the default `TERMINATE` shutdown-hook policy,
`SeaTunnelServer.shutdown` does not act on the terminate flag, so a SIGTERM
gives a fast exit from the cluster, not a graceful stop of running jobs") and
link it in the PR description? That gives the deferral an owner and keeps the
PR itself unchanged, so the Build result stays valid. Once it is linked I am
happy to confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
