DanielLeens commented on PR #12710: URL: https://github.com/apache/seatunnel/pull/12710#issuecomment-6313630310
Thanks @SEZ9 for the careful re-check on `016f3d4c`. One small factual correction so the thread stays accurate: the grace period is not opt-in in the chart defaults. `deploy/kubernetes/seatunnel/values.yaml:48` (master) and `:114` (worker) both set `terminationGracePeriodSeconds: 30`, and `deployment-seatunnel-master.yaml:43-44` / `deployment-seatunnel-worker.yaml:43-44` render it. Only an explicit `0` is treated as unset (Kubernetes default, which is also 30s), so the effective behavior is the same either way and nothing needs to change in the PR. Agreed on the remaining gates: the linked follow-up issue for the `SeaTunnelServer.shutdown` terminate-flag question (@ricky2129, it is not in the PR description yet) and a green Build on this exact head. The Build is still failing; as noted in my last pass, if it is the unrelated fault-tolerance flake, rerunning only the failed job is the right next step. No new commit came with this discussion, so I am not publishing a new full review. Once those two are in, I am happy to re-approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
