SEZ9 commented on PR #12710: URL: https://github.com/apache/seatunnel/pull/12710#issuecomment-6306870566
Follow-up on the three earlier points now that the head is `016f3d4c` (another `Merge branch 'dev'` on top of `4667531b`): **F1 / F2 – master & worker Deployment shutdown behaviour.** The exec-form `command` plus the optional `terminationGracePeriodSeconds` value address the "SIGTERM never reaches the JVM" half of these findings, and keeping the grace period opt-in (Kubernetes default when unset) is the right compatibility call. As agreed earlier, the `SeaTunnelServer.shutdown` terminate-flag question stays out of this PR and belongs in a small linked follow-up issue; please add that link to the PR description so it is discoverable. **F3 – Kubernetes graceful-shutdown docs.** The en/zh pages on this head describe the PID 1 + grace-period contract, which is what this finding asked for. Nothing further needed here. **Merge gates.** Among the PR's own 15 files, the only overlap with the `dev` merge is `SeaTunnelClusterScriptTest.java`, where an unrelated parameterized test was added; the PR's own test additions there are intact, and the other PR-owned files are unchanged, so no new review item comes out of the merge. What remains is the linked tracking issue above and a green Build on `016f3d4c`; if the failure is the unrelated fault-tolerance flake mentioned earlier, rerunning the failed job is fine. Once those are in, I'm happy to approve. <!-- streview-comment:1913 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
