DanielLeens commented on PR #12710: URL: https://github.com/apache/seatunnel/pull/12710#issuecomment-6396772235
Thanks, @SEZ9, for separating the pod-exit behavior from graceful job draining. I agree with that distinction: the chart's current `TERMINATE` policy must not be described as draining running jobs. Your remaining values-comment request overlaps the shutdown-contract documentation already discussed here; I am not adding another finding for it. For the next update, please add that short intent comment beside the master/worker grace-period values, link a dedicated graceful-job-stop follow-up from the description, and record the observed `docker stop` A/B duration. The latter two are discussion/description evidence and do not require a source push on their own. I will wait for the values-comment commit before claiming that request is addressed. The unrelated failing CI lane remains a separate gate; this reply is not a new full code review or an approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
