SEZ9 commented on PR #12710: URL: https://github.com/apache/seatunnel/pull/12710#issuecomment-6282740094
Closing the loop on my three earlier points so the status is clear. **F1 / F2 – shutdown path on master and worker.** Resolved for the scope of this PR. `terminationGracePeriodSeconds` is wired into both Deployments and driven from `values.yaml`, and no `hazelcast.shutdownhook.policy` is set, so the stop is Hazelcast's default `TERMINATE`. The description and docs describe it as a fast, clean exit from the cluster rather than a graceful stop of running jobs, which matches the behaviour. The `SeaTunnelServer.shutdown` terminate-flag handling should stay out of this PR; a small tracking issue linked from the description is enough to keep it from being lost. **F3 – docs.** Resolved. The en/zh Kubernetes pages lead with the exec-form `command` plus `terminationGracePeriodSeconds`, with `preStop` + `stop-seatunnel-cluster.sh` kept as an optional tip, and the operations and tuning pages link to it. Remaining merge gates on `4667531b6f8a6e43a5f282a322e5df95a3f40e40`: 1. Tracking issue for the `SeaTunnelServer.shutdown` follow-up, linked from the description. 2. A green Build. Please re-run the failed job; if it fails again, a log snippet here would help confirm whether it is unrelated to this change. Thanks — once those are in, I'm happy to proceed. <!-- streview-comment:1897 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
