SEZ9 commented on PR #12710: URL: https://github.com/apache/seatunnel/pull/12710#issuecomment-6331989480
Thanks for keeping this current on `016f3d4c`. Re-checking against my earlier findings on `4667531b`: **F1 / F2 (master + worker Deployments – grace period / shutdown policy):** the chart part is resolved. `deploy/kubernetes/seatunnel/values.yaml:48` (master) and `:114` (worker) now default `terminationGracePeriodSeconds: 30`, and `deployment-seatunnel-master.yaml:43-44` / `deployment-seatunnel-worker.yaml:43-44` render it, with only an explicit `0` falling back to the Kubernetes default. Since the effective behaviour is identical either way, nothing more is needed in the templates. The one piece of F1/F2 still open is the `SeaTunnelServer.shutdown` terminate-flag question. I'm fine keeping that out of this PR, but please open the follow-up issue and link it in the PR description — it is not there yet, and I'd like the deferral recorded rather than just discussed in this thread. **F3 (docs):** the en/zh Kubernetes graceful-shutdown docs now describe the `exec`-based path instead of presenting the `preStop` + `stop-seatunnel-cluster.sh` workaround as the only way to a clean stop, which closes this one. Remaining asks before I re-approve: 1. Linked follow-up issue for the `SeaTunnelServer.shutdown` terminate-flag handling, referenced in the PR description. 2. A green Build on this exact head. The Build is currently failing; if it is the unrelated fault-tolerance flake, please re-run just the failed job and ping me. No code changes required at this point. <!-- streview-comment:1947 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
