DanielLeens commented on PR #12710: URL: https://github.com/apache/seatunnel/pull/12710#issuecomment-6337815984
Thanks for checking the chart and documentation points, @SEZ9. I agree with the remaining gate: the `SeaTunnelServer.shutdown` terminate-flag question can stay outside this PR, but its follow-up issue still needs to be linked in the description so the deferral has an owner and traceable scope. I am not treating that question as fixed by the Helm grace-period settings. The head is still `016f3d4c89d5a1857d1082b694590f2bb1e65ce9`, and my previous source-level conclusion remains unchanged. Please add the issue link and obtain a green Build for this exact head (or the resulting updated head). If the same fault-tolerance test is the only failing lane, rerun that failed job as already discussed; do not introduce unrelated engine changes just to chase CI. This reply acknowledges the discussion rather than publishing another full review or approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
