[ 
https://issues.apache.org/jira/browse/AVRO-3368?focusedWorklogId=723848&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723848
 ]

ASF GitHub Bot logged work on AVRO-3368:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Feb/22 17:37
            Start Date: 09/Feb/22 17:37
    Worklog Time Spent: 10m 
      Work Description: zcsizmadia commented on pull request #1519:
URL: https://github.com/apache/avro/pull/1519#issuecomment-1034022677


   You indicated that these changes were trying to solve the maintainability 
issue of the codebase and referred the confluent kafka ticket. I dont really 
see that these changes are really helping there.  I understand your point of 
view about this particular issue in this ticket, however if we have only couple 
of cases we have to fix, it sounds reasonable. But if we havemany of these 
variables, I am not sure that is thway to go.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 723848)
    Time Spent: 3.5h  (was: 3h 20m)

>  Remove accessible field value from GenericFixed
> ------------------------------------------------
>
>                 Key: AVRO-3368
>                 URL: https://issues.apache.org/jira/browse/AVRO-3368
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.11.0
>            Reporter: Kyle Schoonover
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Update:
> {code:java}
> protected readonly byte[] value; {code}
> to:
> {code:java}
> [Obsolete("Will deprecate in future release use Value property")]
> protected byte[] value
> {
>     get { return _value; }
> }        
> /// <summary>
> /// Value of this fixed schema.
> /// </summary>
> private readonly byte[] _value; {code}
> Additional changes will need to be made to change everything from value to 
> _value



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to