[
https://issues.apache.org/jira/browse/AVRO-3368?focusedWorklogId=723849&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723849
]
ASF GitHub Bot logged work on AVRO-3368:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/22 17:39
Start Date: 09/Feb/22 17:39
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on pull request #1519:
URL: https://github.com/apache/avro/pull/1519#issuecomment-1034024565
Right now, the first things is just styling cleanup.
The quickest and easiest is spacing, which is actually a lot of rules
(https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/formatting-rules)
The next step is naming (which is basically what this file is). Note, I've
tried to work one file at a time in order to keep my PR's small.
-
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0001
-
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0002
-
https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0003-ide0009
Naming would additionally include setting prefixes.
The easiest way to put this is: 0 Errors, 0 Warning, 0 Messages is the long
term goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 723849)
Time Spent: 3h 40m (was: 3.5h)
> Remove accessible field value from GenericFixed
> ------------------------------------------------
>
> Key: AVRO-3368
> URL: https://issues.apache.org/jira/browse/AVRO-3368
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Update:
> {code:java}
> protected readonly byte[] value; {code}
> to:
> {code:java}
> [Obsolete("Will deprecate in future release use Value property")]
> protected byte[] value
> {
> get { return _value; }
> }
> /// <summary>
> /// Value of this fixed schema.
> /// </summary>
> private readonly byte[] _value; {code}
> Additional changes will need to be made to change everything from value to
> _value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
