+1 to trying the release with gradle for 2.5, falling back if it doesn't work. We'd rather find issues sooner than later.
For newcommers, I don't know that our maven setup was any more understandable than our gradle one, especially for those not already in the Java world. I am somewhat split on the being explicit vs. being idiomatic debate though. Regarding the source release artifact, I don't think it should have the poms, right? It should literally be "wget https://github.com/apache/beam/archive/[release-commit].zip"; On Mon, Apr 9, 2018 at 12:56 PM Lukasz Cwik <lc...@google.com> wrote: > Romain, I was under the impression that the source tar ball that is > uploaded to www.apache.org/dist/ is required to be buildable and is a > separate deliverable from the artifacts (jars > (source/test/javadoc/...)/poms) uploaded to > https://repository.apache.org/service/local/staging/deploy/maven2. > > The source tar ball uploaded to www.apache.org/dist/ will contain the > gradle build files allowing one to reproduce the artifacts (jars > (source/test/javadoc)/poms). > > On Mon, Apr 9, 2018 at 3:44 PM Romain Manni-Bucau <rmannibu...@gmail.com> > wrote: > >> >> >> Le 9 avr. 2018 16:06, "Lukasz Cwik" <lc...@google.com> a écrit : >> >> >> >> On Mon, Apr 9, 2018 at 10:02 AM Romain Manni-Bucau <rmannibu...@gmail.com> >> wrote: >> >>> I got the same with that PR applied and the previous command. Is using >>> your fork needed? >> >> No, you can also use https://github.com/apache/beam/pull/5048 >> >> >>> Is there any PR to import it? >>> >> Yes, https://github.com/apache/beam/pull/5048 >> >> >> >> Ok so it doesnt work and generates a pom without parent nor dependencies >> which is a bare minimum but not enough since exploding the sources jar and >> running the pom should build a valid jar. >> >> >> In any case master is not ready to be released with that yet - to come >>> back to the actual topic. >> >> >>> Romain Manni-Bucau >>> @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book >>> >>> >>> 2018-04-09 15:56 GMT+02:00 Lukasz Cwik <lc...@google.com>: >>> > Romain, >>> > The gradle based release process has an open PR in >>> > https://github.com/apache/beam/pull/5048 to merge to master. >>> > I thought you were running the commands from >>> > https://github.com/lukecwik/incubator-beam/tree/gradle >>> > >>> > On Mon, Apr 9, 2018 at 9:13 AM Romain Manni-Bucau < >>> rmannibu...@gmail.com> >>> > wrote: >>> >> >>> >> @Lukasz: same with gradlew and release option, pom is empty (no >>> parent, no >>> >> dependencies, no more description - needed since central poms use >>> that for >>> >> doc purposes). >>> >> >>> >> >>> >> Romain Manni-Bucau >>> >> @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book >>> >> >>> >> 2018-04-09 15:00 GMT+02:00 Reuven Lax <re...@google.com>: >>> >>> >>> >>> Is everything needed merged into master? >>> >>> >>> >>> If so, why don't we try doing it with Gradle, but "fail fast" back to >>> >>> Maven if something doesn't work. If something doesn't quite work I >>> don't >>> >>> think we should delay 2.5.0 while we fix it, when we can still do >>> 2.5.0 with >>> >>> Maven. >>> >>> >>> >>> Reuven >>> >>> >>> >>> On Mon, Apr 9, 2018 at 12:58 PM Lukasz Cwik <lc...@google.com> >>> wrote: >>> >>>> >>> >>>> I would rather have the community try doing the 2.5.0 release with >>> >>>> Gradle and to fix the issues while people are currently focusing on >>> the >>> >>>> migration and not 6 weeks from now when the 2.6.0 release starts. >>> We can >>> >>>> always fallback to Maven if the community thinks its not ready. If >>> we go >>> >>>> with using Gradle, we should wait till the docs get updated so >>> people >>> >>>> working on the release know how to do it. >>> >>>> >>> >>>> Romain, use `./gradlew publishToMavenLocal -Prelease` to publish the >>> >>>> release candidate version to Maven local. >>> >>>> >>> >>>> >>> >>>> >>> >>>> On Mon, Apr 9, 2018 at 8:47 AM Romain Manni-Bucau >>> >>>> <rmannibu...@gmail.com> wrote: >>> >>>>> >>> >>>>> Surely did something wrong launching: gradle [build] >>> >>>>> publishToMavenLocal >>> >>>>> >>> >>>>> >>> >>>>> >>> >>>>> $ cat >>> >>>>> >>> ~/.m2/repository/org/apache/beam/beam-sdks-java-core/2.5.0-SNAPSHOT/beam-sdks-java-core-2.5.0-SNAPSHOT.pom >>> >>>>> <?xml version="1.0" encoding="UTF-8"?> >>> >>>>> <project xmlns="http://maven.apache.org/POM/4.0.0"; >>> >>>>> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 >>> >>>>> http://maven.apache.org/xsd/maven-4.0.0.xsd"; >>> >>>>> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";> >>> >>>>> <modelVersion>4.0.0</modelVersion> >>> >>>>> <groupId>org.apache.beam</groupId> >>> >>>>> <artifactId>beam-sdks-java-core</artifactId> >>> >>>>> <version>2.5.0-SNAPSHOT</version> >>> >>>>> <name>Apache Beam :: SDKs :: Java :: Core</name> >>> >>>>> </project> >>> >>>>> >>> >>>>> >>> >>>>> Doesn't seem that ready ;) >>> >>>>> >>> >>>>> >>> >>>>> >>> >>>>> Romain Manni-Bucau >>> >>>>> @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book >>> >>>>> >>> >>>>> 2018-04-09 14:38 GMT+02:00 Romain Manni-Bucau < >>> rmannibu...@gmail.com>: >>> >>>>>> >>> >>>>>> I will check now what's the pom status, if they are ok it can be >>> worth >>> >>>>>> testing gradle >>> >>>>>> >>> >>>>>> >>> >>>>>> Romain Manni-Bucau >>> >>>>>> @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book >>> >>>>>> >>> >>>>>> 2018-04-09 14:36 GMT+02:00 Jean-Baptiste Onofré <j...@nanthrax.net >>> >: >>> >>>>>>> >>> >>>>>>> Hi Reuven, >>> >>>>>>> >>> >>>>>>> that was on of the question. I proposed to stay with Maven for >>> 2.5.0 >>> >>>>>>> and switch >>> >>>>>>> to Gradle to 2.6.0 (in order for us to stabilize gradle build). >>> But, >>> >>>>>>> it may >>> >>>>>>> worth to try 2.5.0 with Gradle. >>> >>>>>>> >>> >>>>>>> Regards >>> >>>>>>> JB >>> >>>>>>> >>> >>>>>>> On 04/09/2018 02:27 PM, Reuven Lax wrote: >>> >>>>>>> > To the folks working on Gradle last week - are we at the point >>> >>>>>>> > where we can try >>> >>>>>>> > running this release purely using Gradle, or should we wait >>> until >>> >>>>>>> > 2.6.0? >>> >>>>>>> > >>> >>>>>>> > Reuven >>> >>>>>>> > >>> >>>>>>> > On Mon, Apr 9, 2018 at 8:01 AM Jean-Baptiste Onofré >>> >>>>>>> > <j...@nanthrax.net >>> >>>>>>> > <mailto:j...@nanthrax.net>> wrote: >>> >>>>>>> > >>> >>>>>>> > Up ? >>> >>>>>>> > >>> >>>>>>> > Regards >>> >>>>>>> > JB >>> >>>>>>> > >>> >>>>>>> > On 04/06/2018 10:48 AM, Jean-Baptiste Onofré wrote: >>> >>>>>>> > > Hi guys, >>> >>>>>>> > > >>> >>>>>>> > > Apache Beam 2.4.0 has been released on March 20th. >>> >>>>>>> > > >>> >>>>>>> > > According to our cycle of release (roughly 6 weeks), we >>> >>>>>>> > should think about >>> >>>>>>> > 2.5.0. >>> >>>>>>> > > >>> >>>>>>> > > I'm volunteer to tackle this release. >>> >>>>>>> > > >>> >>>>>>> > > I'm proposing the following items: >>> >>>>>>> > > >>> >>>>>>> > > 1. We start the Jira triage now, up to Tuesday >>> >>>>>>> > > 2. I would like to cut the release on Tuesday night >>> (Europe >>> >>>>>>> > time) >>> >>>>>>> > > 2bis. I think it's wiser to still use Maven for this >>> release. >>> >>>>>>> > Do you think we >>> >>>>>>> > > will be ready to try a release with Gradle ? >>> >>>>>>> > > >>> >>>>>>> > > After this release, I would like a discussion about: >>> >>>>>>> > > 1. Gradle release (if we release 2.5.0 with Maven) >>> >>>>>>> > > 2. Isolate release cycle per Beam part. I think it would >>> be >>> >>>>>>> > interesting to >>> >>>>>>> > have >>> >>>>>>> > > different release cycle: SDKs, DSLs, Runners, IOs. That's >>> >>>>>>> > another >>> >>>>>>> > discussion, I >>> >>>>>>> > > will start a thread about that. >>> >>>>>>> > > >>> >>>>>>> > > Thoughts ? >>> >>>>>>> > > >>> >>>>>>> > > Regards >>> >>>>>>> > > JB >>> >>>>>>> > > >>> >>>>>>> > >>> >>>>>>> > -- >>> >>>>>>> > Jean-Baptiste Onofré >>> >>>>>>> > jbono...@apache.org <mailto:jbono...@apache.org> >>> >>>>>>> > http://blog.nanthrax.net >>> >>>>>>> > Talend - http://www.talend.com >>> >>>>>>> > >>> >>>>>>> >>> >>>>>>> -- >>> >>>>>>> Jean-Baptiste Onofré >>> >>>>>>> jbono...@apache.org >>> >>>>>>> http://blog.nanthrax.net >>> >>>>>>> Talend - http://www.talend.com >>> >>>>>> >>> >>>>>> >>> >>>>> >>> >> >>> > >>> >> >>
