Testing for CB-13870 showed that is is not only `cordova requirements` that is broken with a new installation of VS2017, but the whole build process is wonky: https://issues.apache.org/jira/browse/CB-13872
There is a workaround setting an env var VSINSTALLDIR, but that is undocumented: https://forum.ionicframework.com/t/building-windows-10-app/92416/9 Lucky for us MS seems to be aware of the problem, so this exists: https://github.com/Microsoft/vswhere `%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere" -all -requires Microsoft.Component.MSBuild -property installationPath` returns the correct path we want to look for the build tools, so we can probably use that. I will have to rewrite the MSBuildTools.js a bit, but that isn't the worst idea anyway as it evolved over time and also has strange duplication. J 2018-02-12 14:52 GMT+01:00 Jan Piotrowski <piotrow...@gmail.com>: > After some investigration I now understand the problem, see the update > on CB-13870. I consider this a blocking bug for a release of 6.0.0 as > `cordova requirements` functionality is broken with current tooling. > > Let's see if we can fix this... > > J > > 2018-02-12 13:42 GMT+01:00 Jan Piotrowski <piotrow...@gmail.com>: >> Well, during some more testing I noticed problems with `cordova >> requirements`: >> >>> λ cordova requirements >>> Requirements check results for windows: >>> Windows OS: not installed >>> Error: Cannot read property 'os' of undefined >> >> The same is true for running `bin/check_reqs` directly which should do >> the same/similar thing. After looking into that it seems like this way >> to check the reqs is broken since a few years, so this is not a new >> thing and won't hold up the release by itself, but I created two >> issues about it: https://issues.apache.org/jira/browse/CB-13868 >> https://issues.apache.org/jira/browse/CB-13869 >> >> Back to `cordova requirements`: This also seems to be a follow up >> problem of the change of the default platform from `8.1` to `UAP` - in >> this case the script knows nothing about "UAP" but only "10.0". >> Further I then noticed that different checks (VS2017 and MSBuild) are >> missing version numbers here - so this currently can not work with >> current tooling. >> Issue for this is here: https://issues.apache.org/jira/browse/CB-13870 >> >> This will take some time :/ >> >> J >> >> 2018-02-11 2:03 GMT+01:00 Chris Brody <chris.br...@gmail.com>: >>> On Fri, Feb 9, 2018 at 8:01 PM, Terence M. Bandoian <tere...@tmbsw.com> >>> wrote: >>> >>>> I'm not sure they're what you're looking for but there are three >>>> version-related Windows preferences that seem to be supported in >>>> config.xml: >>>> >>>> <preference name="windows-target-version" value="10.0" /> >>>> <preference name="Windows.Universal-MinVersion" >>>> value="10.0.14393.0" /> >>>> <preference name="Windows.Universal-MaxVersionTested" >>>> value="10.0.16299.125" /> >>>> >>>> Does one or more of these resolve this? >>> >>> >>> Does not seem to work for me >>> >>> >>> On 2/9/2018 6:41 PM, Jesse wrote: >>>> >>>>> Created an issue for making this configurable. CB-13862 >>>>> >>>> >>> +1 >>> >>> On Fri, Feb 9, 2018 at 4:23 PM, Jesse <purplecabb...@gmail.com> wrote: >>>>> >>>>> All correct and I agree, except we do need to update TargetPlatformVersion >>>>>> pr here: https://github.com/apache/cordova-windows/pull/250 >>>>>> Please test this pr on your windows machine and make sure you can create >>>>>> and run a new cordova-windows project without having to modify the jsproj >>>>>> file manually. >>>>>> >>>>> >>> +1. As I said in cordova-windows PR#250 it works for me on Visual Studio >>> 2015 and Visual Studio 2017. Ship it! >>> >>> >>> >>>> On Fri, Feb 9, 2018 at 3:37 PM, Jan Piotrowski <piotrow...@gmail.com> >>>>>> wrote: >>>>>> >>>>>> To recap: >>>>>>> - We think the test failure is a problem only happening on AppVeyor >>>>>>> and should not affect actual users >>>>>>> - We are ok with starting a 6.0.0 release with the current `master` >>>>>>> state with this one failing test on AppVeyor >>>>>>> - We "pledge" to further look into it and release 6.0.1 or 6.1.0 if we >>>>>>> indeed find the solution >>>>>>> >>>>>>> Agree? >>>>>>> >>>>>> >>> +1 agreed on my part >>> >>> >>>> If so, I will start the release process until Monday. >>>>>>> >>>>>> >>> +100 >>> >>> >>>> PS: I will contact AppVeyor to find out if they can maybe help - >>>>>>> blocked file, maybe because of some other running process? >>>>>>> >>>>>> >>> +1 thanks! --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org
