Github user mattf-horton commented on a diff in the pull request:
    --- Diff: 
    @@ -34,15 +34,15 @@
        * @param rawMessage
        * @return If null is returned, this is treated as an empty list.
    -  List<T> parse(byte[] rawMessage);
    +  List<T> parse(byte[] rawMessage, SensorParserConfig sensorParserConfig);
    --- End diff --
    +1, with the following caveats:
    1. Since parser.configure() takes a (Map<String, Object> parserConfig) 
argument, so should parser.configurationChanged(), rather than a 
sensorParserConfig.  I would also name it parser.configurationUpdate() rather 
than parser.configurationChanged(), but that's obviously minor.
    2. Very nice hooking into updateConfig(), BUT we can't call 
parser.configurationUpdate() asynchronously.  Weird things might happen if it's 
in the middle of a message.  Instead, please set a local flag asynchronously in 
ParserBolt, then at each message check-and-clear the flag, and conditionally 
call parser.configurationUpdate() before parser.parseOptional().

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to