Github user mattf-horton commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/308#discussion_r83489303
  
    --- Diff: 
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/interfaces/MessageParser.java
 ---
    @@ -34,15 +34,15 @@
        * @param rawMessage
        * @return If null is returned, this is treated as an empty list.
        */
    -  List<T> parse(byte[] rawMessage);
    +  List<T> parse(byte[] rawMessage, SensorParserConfig sensorParserConfig);
    --- End diff --
    
    Hah, didn't think about Java 8 default methods in interfaces.  Of course, 
you're right.
    
    Your above last set of changes looks excellent, but in GrokParser the 
methods configurationUpdate() and init() have to become synchronized methods.  
Then I think the code as written allows the configurationUpdated flag to not 
need further locking, altho different ordering of things might require 
synchronized get/set/check methods.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to