Github user merrimanr commented on a diff in the pull request:
    --- Diff: 
    @@ -34,15 +34,15 @@
        * @param rawMessage
        * @return If null is returned, this is treated as an empty list.
    -  List<T> parse(byte[] rawMessage);
    +  List<T> parse(byte[] rawMessage, SensorParserConfig sensorParserConfig);
    --- End diff --
    Ok here are the changes to address your caveats:
    method added to MessageParser:
    default void configurationUpdated(Map<String, Object> config) {
    method added to ParserBolt:
      public void updateConfig(String path, byte[] data) throws IOException {
        super.updateConfig(path, data);
        if (path.startsWith(ConfigurationType.PARSER.getZookeeperRoot() + "/" + 
getSensorType())) {
    method added to GrokParser:
      private boolean configurationUpdated = false;
      public void configurationUpdated(Map<String, Object> parserConfig) {
        configurationUpdated = true;
    and GrokParser.parse method changed to:
      public List<JSONObject> parse(byte[] rawMessage) {
        if (grok == null || configurationUpdated) {
          configurationUpdated = false;

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to