Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/308#discussion_r83483903
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/interfaces/MessageParser.java
---
@@ -34,15 +34,15 @@
* @param rawMessage
* @return If null is returned, this is treated as an empty list.
*/
- List<T> parse(byte[] rawMessage);
+ List<T> parse(byte[] rawMessage, SensorParserConfig sensorParserConfig);
--- End diff --
Are there any user-developed parsers out there that don't subclass either
BasicParser or GrokParser? If so, they'll break on the new call to the new
method in MessageParser. If this is a concern, it can be avoided by making
"ConfiguredMessageParser extends MessageParser" and putting the new
configurationUpdate() method there. GrokParser would be the only current
implementation of ConfiguredMessageParser, and the call to
parser.configurationUpdate() in ParserBolt would be made conditional on
"(parser instanceof ConfiguredMessageParser)"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
