Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/308#discussion_r83749198
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java
---
@@ -116,6 +122,9 @@ public void execute(Tuple tuple) {
boolean ackTuple = !writer.handleAck();
int numWritten = 0;
if(sensorParserConfig != null) {
+ if (configUpdatedFlag.getAndSet(false)) {
+
parser.configurationUpdated(getSensorParserConfig().getParserConfig());
--- End diff --
You're right that's definitely incorrect. I think it would be safer if we
use the config object fetched in line 118 though. Is there a benefit to
updating the config in the middle of the execute method? We're already
delaying the change in the parser until the next execute.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
