Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/308#discussion_r83746685
--- Diff:
metron-platform/metron-parsers/src/main/java/org/apache/metron/parsers/bolt/ParserBolt.java
---
@@ -116,6 +122,9 @@ public void execute(Tuple tuple) {
boolean ackTuple = !writer.handleAck();
int numWritten = 0;
if(sensorParserConfig != null) {
+ if (configUpdatedFlag.getAndSet(false)) {
+
parser.configurationUpdated(getSensorParserConfig().getParserConfig());
--- End diff --
nice catch on the need to re-call getSensorParserConfig(). But I think it
needs to be captured in the sensorParserConfig variable for use in lines 132
and 134, eg:
if (configUpdatedFlag.getAndSet(false)) {
sensorParserConfig = getSensorParserConfig(); //re-fetch in case
it's changed
parser.configurationUpdated(sensorParserConfig.getParserConfig());
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
