We could make 0.5.x the last version that supports 1.6.x and simply upgrade logic to use liquibase.xml.
Backporting (or forward-porting) changes from a mavenized module to a premaven build is annoying and takes 10x longer to do. Is there a reason we can't create the branch off of the mavenized version? You'll thank me later... Ben On Fri, Aug 26, 2011 at 12:44 AM, Darius Jazayeri <[email protected]>wrote: > Done, and assigned. > > > On Thu, Aug 25, 2011 at 2:31 PM, Saptarshi Purkayastha > <[email protected]>wrote: > >> Created a ticket here: https://tickets.openmrs.org/browse/LOGIC-90 >> ... someone needs to asses it, before I can claim it! >> >> --- >> Regards, >> Saptarshi PURKAYASTHA >> >> My Tech Blog: http://sunnytalkstech.blogspot.com >> You Live by CHOICE, Not by CHANCE >> >> >> On 26 August 2011 02:54, Darius Jazayeri <[email protected]> wrote: >> >>> Patches welcome. :-) >>> >>> Logic needs to run on 1.6.x, so we can't use liquibase. >>> >>> It's fine to change the existing SQL scripts in-place, since there's no >>> checksum, like in liquibase. >>> >>> -Dar >>> >>> On Thu, Aug 25, 2011 at 1:26 PM, Saptarshi Purkayastha <[email protected] >>> > wrote: >>> >>>> ... and after the branching happens, can someone change the SQL scripts >>>> that are inside the sqldiff.xml to be ANSI SQL compatible in the trunk. >>>> Or atleast use liquibase like xmls ?? >>>> >>>> Since Logic is a core module without which OpenMRS won't start... I've >>>> had a hard time to make OpenMRS run on all database servers. >>>> >>>> --- >>>> Regards, >>>> Saptarshi PURKAYASTHA >>>> >>>> My Tech Blog: http://sunnytalkstech.blogspot.com >>>> You Live by CHOICE, Not by CHANCE >>>> >>>> >>>> >>>> On 26 August 2011 01:47, Darius Jazayeri <[email protected]>wrote: >>>> >>>>> For what it's worth, no actual development has happened on logic since >>>>> February, which is basically when logic 0.5 was released. My intent at the >>>>> time was to not create the 0.5.x branch until we actually had development >>>>> work happening on a new feature. >>>>> >>>>> Though since logic was mavenized, I think it's definitely right to make >>>>> a pre-maven 0.5.x branch. Win, what revision did you branch the 0.5.x >>>>> branch >>>>> from? I believe there are some commits after the 0.5 tag that should be >>>>> backported to the 0.5 branch. >>>>> >>>>> Alternately, if nobody has started using the 0.5.x branch yet, could we >>>>> delete that and branch it right after rev:18407 (the last pre-maven >>>>> commit, >>>>> in February, by Tammy)? >>>>> >>>>> -Darius >>>>> >>>>> On Wed, Aug 24, 2011 at 1:37 PM, Nyoman Ribeka <[email protected]>wrote: >>>>> >>>>>> 0.5.x branch created. >>>>>> >>>>>> -Win >>>>>> >>>>>> On Wed, 2011-08-24 at 14:16 -0400, Tammy Dugan wrote: >>>>>> > Thanks, Burke. >>>>>> > >>>>>> > Tammy >>>>>> > >>>>>> > On 8/24/2011 1:58 PM, Burke Mamlin wrote: >>>>>> > > Trunk has followed the pattern of creating a "major.minor.x" >>>>>> branch >>>>>> > > and tagging from there, allowing for select bug fixes from trunk >>>>>> to >>>>>> > > be backported to that branch and, as needed, new maintenance >>>>>> > > releases to be tagged off that branch. That approach has worked >>>>>> > > pretty well for trunk. It's overkill for small or less-used >>>>>> > > modules, but logic probably warrants following it. >>>>>> > > >>>>>> > > >>>>>> > > -Burke >>>>>> > > >>>>>> >>>>>> _________________________________________ >>>>>> >>>>>> To unsubscribe from OpenMRS Developers' mailing list, send an e-mail >>>>>> to [email protected] with "SIGNOFF openmrs-devel-l" in the >>>>>> body (not the subject) of your e-mail. >>>>>> >>>>>> [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l] >>>>>> >>>>> >>>>> >>>> ------------------------------ >>>> Click here to >>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >>>> OpenMRS Developers' mailing list >>> >>> >>> >> ------------------------------ >> Click here to >> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >> OpenMRS Developers' mailing list >> > > ------------------------------ > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list > _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
