[
https://issues.apache.org/jira/browse/PHOENIX-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247410#comment-14247410
]
Nick Dimiduk commented on PHOENIX-1514:
---------------------------------------
Verification without my changes are still running, this is the only failure so
far:
{noformat}
testStarJoin[1](org.apache.phoenix.end2end.HashJoinIT) Time elapsed: 0.731 sec
<<< ERROR!
java.lang.NullPointerException: null
at
org.apache.phoenix.cache.ServerCacheClient.removeServerCache(ServerCacheClient.java:285)
at
org.apache.phoenix.cache.ServerCacheClient.access$000(ServerCacheClient.java:80)
at
org.apache.phoenix.cache.ServerCacheClient$ServerCache.close(ServerCacheClient.java:140)
at
org.apache.phoenix.util.SQLCloseables.closeAllQuietly(SQLCloseables.java:53)
at org.apache.phoenix.util.SQLCloseables.closeAll(SQLCloseables.java:43)
at
org.apache.phoenix.execute.BaseQueryPlan$1.close(BaseQueryPlan.java:235)
at
org.apache.phoenix.jdbc.PhoenixResultSet.close(PhoenixResultSet.java:140)
at
org.apache.phoenix.util.SQLCloseables.closeAllQuietly(SQLCloseables.java:53)
at org.apache.phoenix.util.SQLCloseables.closeAll(SQLCloseables.java:43)
at
org.apache.phoenix.jdbc.PhoenixStatement.close(PhoenixStatement.java:964)
at
org.apache.phoenix.util.SQLCloseables.closeAllQuietly(SQLCloseables.java:53)
at org.apache.phoenix.util.SQLCloseables.closeAll(SQLCloseables.java:43)
at
org.apache.phoenix.jdbc.PhoenixConnection.closeStatements(PhoenixConnection.java:378)
at
org.apache.phoenix.jdbc.PhoenixConnection.close(PhoenixConnection.java:392)
at
org.apache.phoenix.end2end.HashJoinIT.testStarJoin(HashJoinIT.java:1876)
{noformat}
{quote}
As far as PhoenixArray, we wouldn't want to hold on to the Integer[]
representation, but instead only the int[] representation, for example, as for
big arrays this could be significant. That's why the array was declared as an
Object. Maybe we can get rid of the declaration completely in the PhoenixArray
type, make it abstract, and only hold on to it in the concrete subclasses?
{quote}
Let me look at this once more. It seemed that there are places where we have an
instance of, say int[], but we try to cast to Object[], which does not work.
This was happening after my refactoring, I think because what was
PDataType$INTEGER_ARRAY now extends PArrayDataType.
> Break up PDataType Enum
> -----------------------
>
> Key: PHOENIX-1514
> URL: https://issues.apache.org/jira/browse/PHOENIX-1514
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 5.0.0
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Fix For: 5.0.0
>
> Attachments: PHOENIX-1514.00.patch, PHOENIX-1514.01.patch,
> PHOENIX-1514.02.patch, hung-phoenix-verify.txt
>
>
> A first step in adopting (a portion of) HBase's type encodings is to break up
> the PDataType enum into an interface. This will pave the way for more
> flexibility going forward.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
