[
https://issues.apache.org/jira/browse/PHOENIX-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248838#comment-14248838
]
James Taylor commented on PHOENIX-1514:
---------------------------------------
I think that something is awry. The following PDataType method should be called
and should instantiate a primitive[] based on the type.
{code}
public static PhoenixArray instantiatePhoenixArray(PDataType actualType,
Object[] elements) {
PhoenixArrayFactory factory = ARRAY_FACTORY[actualType.ordinal()];
if (factory == null) {
throw new IllegalArgumentException("Cannot create an array of " +
actualType);
}
return factory.newArray(actualType, elements);
}
{code}
I think if this is fixed, those tests will pass (and we won't need to hold on
to the Primitive[]).
> Break up PDataType Enum
> -----------------------
>
> Key: PHOENIX-1514
> URL: https://issues.apache.org/jira/browse/PHOENIX-1514
> Project: Phoenix
> Issue Type: Sub-task
> Affects Versions: 5.0.0
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Fix For: 5.0.0
>
> Attachments: PHOENIX-1514.00.patch, PHOENIX-1514.01.patch,
> PHOENIX-1514.02.patch, hung-phoenix-verify.txt, stack.txt
>
>
> A first step in adopting (a portion of) HBase's type encodings is to break up
> the PDataType enum into an interface. This will pave the way for more
> flexibility going forward.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
