[ 
https://issues.apache.org/jira/browse/PHOENIX-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248754#comment-14248754
 ] 

Nick Dimiduk commented on PHOENIX-1514:
---------------------------------------

bq. Let me know if you can fix the problems with int[] being cast to Object[] - 
I think you're right about the cause.

Without some massaging around these arrays, I'm getting a bunch of the UT 
failures trying to cast from primitive\[\] to Object\[\], such as

{noformat}
testForDoubleArray(org.apache.phoenix.schema.PDataTypeForArraysTest)  Time 
elapsed: 0.087 sec  <<< ERROR!
java.lang.ClassCastException: [D cannot be cast to [Ljava.lang.Object;
        at 
org.apache.phoenix.schema.types.PhoenixArray$PrimitiveDoublePhoenixArray.equals(PhoenixArray.java:407)
        at org.junit.Assert.isEquals(Assert.java:131)
        at org.junit.Assert.equalsRegardingNull(Assert.java:127)
        at org.junit.Assert.assertEquals(Assert.java:111)
        at org.junit.Assert.assertEquals(Assert.java:144)
        at 
org.apache.phoenix.schema.PDataTypeForArraysTest.testForDoubleArray(PDataTypeForArraysTest.java:769)
{noformat}

I can explore the path of cleaning up these equality methods, or we can move 
forward with maintaining the two arrays as I have in the current patch.

> Break up PDataType Enum
> -----------------------
>
>                 Key: PHOENIX-1514
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1514
>             Project: Phoenix
>          Issue Type: Sub-task
>    Affects Versions: 5.0.0
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>             Fix For: 5.0.0
>
>         Attachments: PHOENIX-1514.00.patch, PHOENIX-1514.01.patch, 
> PHOENIX-1514.02.patch, hung-phoenix-verify.txt, stack.txt
>
>
> A first step in adopting (a portion of) HBase's type encodings is to break up 
> the PDataType enum into an interface. This will pave the way for more 
> flexibility going forward.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to