Hi Noel, On Tuesday, 2007-07-03 09:25:13 +0100, Noel Power wrote:
> > Would changing the flags set in ScRange::ParseCols() and > > ScRange::ParseRows() have an effect? [...] > > usage in the ScRange methods is wrong and other flag combinations should > > be returned upon success to indicate a valid range. > I have to admit I didn't quite understand what you meant with the flags > etc. ( but I need to look again at this ) The Parse... methods return an USHORT value that is a bitmask of SCA_... constants defined in sc/inc/address.hxx, indicating which parts could be successfully identified as being valid respectively where parsing failed. This enabled us even with the old ScAddress structure (that knew only a BYTE range for sheets and columns and an USHORT for rows) to display a reference as #REF!.A1 if a bad sheet name was entered. Nowadays we could set a part to -1 as well to indicate an invalid value, just that the necessary changes aren't carried out yet. > it's probably best I ping you > ( if that's ok ) when I get back to looking at Range in order to > interrogate you further. Sure. I'll do some modifications to ParseCols() and ParseRows(). Eike -- OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer. OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't send personal mail to this [EMAIL PROTECTED] account, which I use for mailing lists only and don't read from outside Sun. Use [EMAIL PROTECTED] Thanks. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
