Hi Eike, On Mon, 2007-07-02 at 14:32 +0200, Eike Rathke wrote: > Hi Noel, > > On Monday, 2007-07-02 12:00:12 +0100, Noel Power wrote: > > > Finally go a chance to apply the changes from the cws and glad to say > > these changes don't seem to affect the tests that I have :-) > > Would changing the flags set in ScRange::ParseCols() and > ScRange::ParseRows() have an effect? No idea :-( > It doesn't look like, as > source/ui/vba/vbarange.cxx doesn't test for the flags returned (I think > it should, but then again I didn't dive deeper into the code), I don't blame you for not diving deeper, the range class grew somewhat organically as understanding grew ( and is still growing ;-) ) and is now way to complicated, I'd like to re-write it ( one of the reasons why I am concentrating on building lots of tests around this area ) > but the > usage in the ScRange methods is wrong and other flag combinations should > be returned upon success to indicate a valid range. I have to admit I didn't quite understand what you meant with the flags etc. ( but I need to look again at this ) it's probably best I ping you ( if that's ok ) when I get back to looking at Range in order to interrogate you further. > > Eike > Noel -- Noel Power OpenOffice Developer Novell Ireland Software Limited Corrig Court, Corrig Road Sandyford Business Estate, Sandyford Dublin 18 [EMAIL PROTECTED]
Novell, Inc. Software for the Open Enterprise www.novell.com/open SUSE® Linux Enterprise 10 Your Linux is ready www.novell.com/linux Registered No: 223694 --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
