Yep, that patch should be more than sufficient On 21 June 2011 09:32, Lukasz Lenart <[email protected]> wrote: > Maurizio, > > I must apply just that [1], yes ? > > [1] > http://svn.apache.org/viewvc/incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java?r1=1103138&r2=1104581&diff_format=h > > > Regards > -- > Łukasz > + 48 606 323 122 http://www.lenart.org.pl/ > Warszawa JUG conference - Confitura http://confitura.pl/ > > > > 2011/6/14 Maurizio Cucchiara <[email protected]>: >> Hi Martin, >> OGNL has been entered incubation since 2011-04-26 [1]. >> The source code is in an Apache svn repository (unfortunately we have >> not been able to import the full history, since it got lost before its >> time). >> >> Now we have two forks: >> 1. under git-hub >> 2. under the apache svn repository (incubation). >> >> Unfortunately, the latter is not backward-compatible (as Jason said) [2]. >> OTOH Struts is still using the github version of OGNL. >> We think we will replace the git-hub version in the next release. >> >> >> >> [1] http://incubator.apache.org/projects/ognl.html >> [2] http://markmail.org/message/bhl23awyvof3z6b2 >> >> On 14 June 2011 15:32, Martin Cooper <[email protected]> wrote: >>> On Tue, Jun 14, 2011 at 4:08 AM, Lukasz Lenart >>> <[email protected]> wrote: >>>> Just point here, we decided that the best option is to make a new Ognl >>>> release from GitHub source code with Maurizio's patch and number it >>>> 3.0.2. >>> >>> Huh? OGNL is in incubation. The source needs to be in ASF Subversion, >>> as imported from OpenSymphony subversion with full history and >>> provenance. I'd be exceedingly surprised if the mentors have signed up >>> for an ASF incubation release from Github source. Can you point us to >>> a discussion of where this discussion happened? It seems to me that >>> this will sink any chances of a successful short term incubation. >>> That's very bad. >>> >>> -- >>> Martin Cooper >>> >>> >>>> Regards >>>> -- >>>> Łukasz >>>> + 48 606 323 122 http://www.lenart.org.pl/ >>>> Warszawa JUG conference - Confitura http://confitura.pl/ >>>> >>>> >>>> 2011/6/8 Lukasz Lenart <[email protected]>: >>>>> We should ask on OGNL PMC list if we can do that ... >>>>> >>>>> >>>>> Regards >>>>> -- >>>>> Łukasz >>>>> + 48 606 323 122 http://www.lenart.org.pl/ >>>>> Warszawa JUG conference - Confitura http://confitura.pl/ >>>>> >>>>> >>>>> >>>>> 2011/6/8 Maurizio Cucchiara <[email protected]>: >>>>>> OK, I get the point... Frankly, at first glance it looked very >>>>>> familiar.... >>>>>> >>>>>> It's not struts' fault, rather OGNL is the responsible of this issue [1]. >>>>>> This patch [2] solves the problem, but we will face a different >>>>>> problem: this time we have a patch before, but we have not a place >>>>>> where we can apply it. >>>>>> >>>>>> Lucasz, is there a chance to release the 3.0.2 version of OGNL? >>>>>> >>>>>> [1] >>>>>> https://issues.apache.org/jira/browse/OGNL-9?focusedCommentId=13034888&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13034888 >>>>>> [2] >>>>>> http://svn.apache.org/viewvc/incubator/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java?r1=1103138&r2=1104581&diff_format=h >>>>>> >>>>>> On 7 June 2011 18:36, Maurizio Cucchiara <[email protected]> >>>>>> wrote: >>>>>>> and the sad thing that is not yet finished :) >>>>>>> >>>>>>> On 7 June 2011 18:27, Jason Pyeron <[email protected]> wrote: >>>>>>>>> -----Original Message----- >>>>>>>>> From: Maurizio Cucchiara >>>>>>>>> Sent: Tuesday, June 07, 2011 11:41 >>>>>>>>> To: Struts Developers List >>>>>>>>> Subject: Re: Java5 test issues on xwork-core, it passes in Java6 >>>>>>>>> >>>>>>>>> Jason, >>>>>>>>> we are going to know very soon :) >>>>>>>> >>>>>>>> Huston, >>>>>>>> >>>>>>>> We have a problem. >>>>>>>> >>>>>>>> https://builds.apache.org/job/Struts2/312/org.apache.struts.xwork$xwork-core/ >>>>>>>> >>>>>>>>> >>>>>>>>> On 7 June 2011 17:37, Jason Pyeron <[email protected]> wrote: >>>>>>>>> >> -----Original Message----- >>>>>>>>> >> From: Jason Pyeron [mailto:[email protected]] >>>>>>>>> >> Sent: Tuesday, June 07, 2011 11:35 >>>>>>>>> >> To: 'Struts Developers List' >>>>>>>>> >> Subject: RE: Java5 test issues on xwork-core, it passes in Java6 >>>>>>>>> >> >>>>>>>>> >> > -----Original Message----- >>>>>>>>> >> > From: Lukasz Lenart >>>>>>>>> >> > Sent: Tuesday, June 07, 2011 11:27 >>>>>>>>> >> > To: Struts Developers List >>>>>>>>> >> > Subject: Re: Java5 test issues on xwork-core, it passes in Java6 >>>>>>>>> >> > >>>>>>>>> >> > It should pass base on Java 5. It's strange, Jenkins [1] >>>>>>>>> >> runs Struts 2 >>>>>>>>> >> > build on JDK 5 >>>>>>>>> >> > >>>>>>>>> >> > [1] https://builds.apache.org//view/S-Z/view/Struts/job/Struts2/ >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> https://builds.apache.org/view/S-Z/view/Struts/job/Struts2/lastBuild/ >>>>>>>>> >> >>>>>>>>> >> Module Builds >>>>>>>>> >> XWork: Core (didn't run) >>>>>>>>> >> Webapps 2.1 sec >>>>>>>>> > >>>>>>>>> > ??? Ignore me, it was listed at the bottom too >>>>>>>>> > >>>>>>>>> https://builds.apache.org/view/S-Z/view/Struts/job/Struts2/las >>>>>>>> tBuild/org.apache. >>>>>>>>> > struts.xwork$xwork-core/ >>>>>>>>> > >>>>>>>>> > But as Maurizio says jenkins is still running on 1.6 >>>>>>>>> > >>>>>>>>> >> >>>>>>>>> >> >>>>>>>>> >> > >>>>>>>>> >> > >>>>>>>>> >> > Regards >>>>>>>>> >> > -- >>>>>>>>> >> > Lukasz >>>>>>>>> >> > + 48 606 323 122 http://www.lenart.org.pl/ >>>>>>>>> >> > Warszawa JUG conference - Confitura http://confitura.pl/ >>>>>>>>> >> > >>>>>>>>> >> > >>>>>>>>> >> > 2011/6/7 Jason Pyeron <[email protected]>: >>>>>>>>> >> > > Would like some input before filing an issue. >>>>>>>>> >> > > >>>>>>>>> >> > > 1: Should xwork-core be built with java5 or 6? >>>>>>>>> >> > > >>>>>>>>> >> > > 2: If java5, does anyone else have a clean build on >>>>>>>>> >> > revision 1133024? >>>>>>>>> >> > > >>>>>>>>> >> <snip/> >>>>>>>> >>>>>>>> -- >>>>>>>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- >>>>>>>> - - >>>>>>>> - Jason Pyeron PD Inc. http://www.pdinc.us - >>>>>>>> - Principal Consultant 10 West 24th Street #100 - >>>>>>>> - +1 (443) 269-1555 x333 Baltimore, Maryland 21218 - >>>>>>>> - - >>>>>>>> -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- >>>>>>>> This message is copyright PD Inc, subject to license 20080407P00. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> --------------------------------------------------------------------- >>>>>>>> To unsubscribe, e-mail: [email protected] >>>>>>>> For additional commands, e-mail: [email protected] >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Maurizio Cucchiara >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Maurizio Cucchiara >>>>>> >>>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >> >> >> >> -- >> Maurizio Cucchiara >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
-- Maurizio Cucchiara --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
