jkesselm commented on PR #1: URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542580670
1. Historically, in this project, we have NOT used eight-space indentations; I believe we started with four. When in doubt, follow project's existing conventions. And your comment about line length directly conflicts with this request. 2. My auto-formatters (Emacs, Eclipse) happily line up arguments. Most others I've used likewise; it's just a matter of setting the style parameter appropriately. 3. What you're calling "badly formatted code" is established code style for that file/project. If you consider the existing codebase as a whole badly formatted, see your own advice about general reformats. There are many formatting styles, and Oracle's is far from universally accepted. If you want to switch to that, it can be done, but see your own advice about applying that globally as a separate PR -- and if this is a priority for you, seriously consider making the rules being followed part of the codebase and make code reflow part of the commit process. This is not a hill I want to die on, but it's also simply not as important to me as functionality and human-readability. It's also a gratuitous barrier to participation -- and we've recognized that participation is a serious problem for us right now. Nitpicking is fine and appreciated, but should not be a barrier to progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
