jkesselm commented on PR #1: URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542587344
Speaking of nitpicking, I now think I'm *not* accepting the em-dash request as a "friendly amendment". Coding is not typesetting. I'll accept the preference for em-space in javadoc or other text intended primarily for publication, but in a code comment it's really not necessary, or (I would argue) justified. It's a nitpick at best, and potentially a barrier to file searches at the worst. If someone else wants to use em-dash characters in comment text, I am willing to let them do so, but I don't think I consider it an improvement and am backing it out of my submission. If you want to make it a stylistic requirement, we first need to get consensus on an explicit set of style rules and, preferably, automate their application. Again, don't create contribution barriers where they aren't necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
