elharo commented on PR #1: URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1542631630
I think we fundamentally agree. I'm fine with four space indents on continuation lines, or whatever project conventions folks like, provided it's written down somewhere. Are there code conventions for this project? I looked but couldn't find any. Ideally we would also have autoformatters on submit (not format checks but actual formatters running on the source repo) that make formatting nits moot. Absent explicit style guidelines, formatting tends to vary idiosyncratcially from file to file and line to line, and there's a lot of confusing churn as different editors autoformat to different conventions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
