On 03/18/16 22:13, David Woodhouse wrote:

> Rewriting it for this reason is *not* acceptable.

BTW I have no clue why not, if I keep your S-o-b in the first place, and
document the changes. In other projects maintainers rewrite
contributors' patches even, and (at best) credit the contributor with a
tag. I think it's entirely in a maintainer's jurisdiction to adapt the
commit message as he sees fit.

It may be idiosyncratic, and you can yell at me for it; but all that
will do is convince me to avert my eyes when you post an OvmfPkg patch.

Whenever you contribute to a project, do you always start with making a
huge noise, calling everyone around (or their rules) insane, "makes no
sense at all", and so on? The stuff we've been operating by thus far
have been mostly okay. I have updated a few commit messages as well, and
haven't received complaints. The operational changes you are
force-feeding the project (or the rate thereof) seem to surpass all the
changes it has undergone since I started participating.

CRLF has been working out for most people. Rebasing patches has been
working out. Staying away from non-ASCII in commit messages ditto.
Keeping full context when quoting patches ditto. You want edk2 to change
its ways in all aspects at once. And since I seem to be the guy who
talks to you the most, I'm the one you yell at the most. I've never
experienced this before. I'm stunned.

Laszlo
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to