On 18.05.2011 22:45, Csaba Halász wrote: > On Wed, May 18, 2011 at 8:19 PM, ThorstenB<bre...@gmail.com> wrote: >> >> Thanks Csaba, that's already close! I looked at the commit logs but >> didn't find any obvious culprit. A good next test would be r12312 - > > ... which is broken. > Turns out 12303 is the cause for the constant sunshine ;) Great! Excellent you've found it!
> Specifically, the GLSL version parsing has been broken: > > Original code: _glslLanguageVersion = asciiToFloat( langVerStr ); > New code: _glslLanguageVersion = ( asciiToFloat( glslvs.substr( > glslvs.find( "GLSL "+5 ) ).c_str() ) ); > > The version string for me here is simply "3.30" (using fglrx 11.4), so > the old code works but the new one doesn't. > Incidentally, the GL version parsing doesn't work either, because > version string is "3.3.10666 Compatibility Profile Context" and the > code (both the old and the new) expect a decimal number before the > space. > > I can't really believe this is the best way to get version numbers from > opengl. Indeed. And a very good find! I can't believe they've just hard-coded some "+5"s and "+8"s to the index to "parse" the version string. Stuff like this has to fail. Can you please post this find at osg-devel? I could cross-post for you, but then again it'd be good if you could do the follow ups on this. cheers, Thorsten ------------------------------------------------------------------------------ What Every C/C++ and Fortran developer Should Know! Read this article and learn how Intel has extended the reach of its next-generation tools to help Windows* and Linux* C/C++ and Fortran developers boost performance applications - including clusters. http://p.sf.net/sfu/intel-dev2devmay _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
