Jeremias Maerki wrote: > On 18.04.2008 16:51:37 Vincent Hennebert wrote: >> Jeremias Maerki wrote: >>> On 18.04.2008 12:48:53 Vincent Hennebert wrote: >>>> Hi, >>>> >>>> A few comments: >>>> >>>> - some time ago I created a BreakUtil class in the o.a.f.util package. >>>> I think this class and KeepUtil should be put in the same place. >>>> Perhaps we could even merge them into a unique KeepsAndBreaksUtil >>>> class. I don’t really know what the best place would be. I put it in >>>> o.a.f.util because it already contains all sorts of utility classes, >>>> but o.a.f.layoutmgr would also make sense. WDYT? >>> Whatever. >> I let you choose, but please take care of this. > > "Whatever" means: I don't care and you can fix this if it is important > to you.
Yeah, sure, let’s all do our own mess in our own corner and everything will be fine. I’m not asking you to finish my work, so please don’t ask me to finish yours. You created a class that’s closely related to another existing one that’s somewhere else; it’s your responsibility to try and maintain some coherence in the codebase by fixing this. Give me any good reason for not doing this simple thing, other than that you don’t care or you don’t have enough time, and I’m shutting up straight away. But you can’t call for contributors on one side and not do even the most basic cleaning behind you on the other side. Vincent -- Vincent Hennebert Anyware Technologies http://people.apache.org/~vhennebert http://www.anyware-tech.com Apache FOP Committer FOP Development/Consulting
