On Apr 21, 2008, at 12:22, Vincent Hennebert wrote:
My reaction was not so much triggered by this (indeed) minor issue, as
by the fact that once again I was being answered “feel free to
improve”
when asking for cleanup/documentation, and I got tired of it. Each
time,
they were small issues that were not a big deal in themselves, but
when
combined together make the code IMO unnecessarily difficult to
understand. We are dealing with a very complex piece of software,
so it
looks even more important to me to keep the code as clean and readable
as possible. Actually I consider this to be my duty whenever I commit
something, and not spending the little time this requires for that
eludes me completely.
FWIW: I think you do have a major point here. If it really concerns
documentation, it's /always/ better if this is kept up-to-date by the
dev that committed the changes in the first place. Someone else is
much more likely to make errors in interpretation. Only the creator
knows precisely what a certain part of the code is meant to do.
Cleanup is maybe more subjective than documentation (*), but that
said, some simple rules of thumb would probably not hurt here.
In this last case, however, I got the impression (as Jeremias, I
presume) that it was not about documentation or cleanup.
I initially read it more as a suggestion --What would you think
if...? As such, Jeremias' reaction was very understandable to me, and
it surprised me to see it escalate further.
(*) as in: My apartment is clean enough for me, but I know of people
that would get a heart-attack if they entered here... ;-)
Cheers
Andreas
