Per Inge Mathisen wrote:
> I tried unsucessfully to update trunk to latest lua and tolua versions. 
> For some reasons I could not figure out, tolua generated a bad api_gen.c, 
> and the makefile did not regenerate this file for me and thus alert me to 
> the problems before I had already committed the changes. Even 'make 
> maintainer-clean' did not clean out these files.
It has been apparent for some time that the makefiles need work!

> So I had to roll back the repository to the state before I started the 
> upgrade. This generates some unfortunate svn noise, and William's r13000 
> is gone. I am really sorry about that.
That's OK, I try to save everything.  My usual series of commands just
before commit is (for example):

   svn up
   make >&../xxx
   svn diff >../du.12993
   svn ci -F ../ci.log.12993

Yep, I save the command history, too....  I've been a consultant for ~25
years, so I'm fairly compulsive about logging.  ;-)

And I'm pretty sure that it is possible to regenerate the diffs from
different svn versions, too.  But it's not a command that I use regularly,
so I'd have to read the manual....

> Speaking of r13000, I would very much like to see it go in in smaller 
> chunks which are easier to manage when debugging using svn.
Sorry, but these are each tiny changes to a single header file, affecting
many, many files.  I've been doing them in as small increments as possible.

(I was actually thinking about trying *larger* combined ones, hoping that
would be *less* disruptive.  But I'll stick to one .h at a time for now.)

> Also, while on the topic of api_gen.c|h, I do not see why these 
> automatically generated source files are in the repository? All the tools 
> required to generate them are already in the repository.
I agree.  And there was a part of a bug report by a translator on another
list that indicated a problem with keeping them in sync (or something).

Anyway, I'll just poke at S2_1 while you are fixing up trunk.

Freeciv-dev mailing list

Reply via email to