Follow-up Comment #18, patch #4830 (project freeciv):

Still just scrolled through the code (I hope to test it in practice and have
more detailed look within a week)

- Do other clients even compile? You add function to client interface, but the
clients seem not to have even empty implementation to provide the symbol. Real
implementation for gtk2-client should be easy to add anyway.
- New rules should be saved to ruleset in tools/ruledit/rulesave.c
- Header comment (can be mostly copied from some other ruleset) to new ruleset
files needed, format of the multiplier sections need to be documented in all
- No new functions without function header are accepted
- Some uncommented code lines remain (read the patch file through yourself to
notice such cases of changes not you have not meant to include)


Reply to this item at:


  Message sent via/by Gna!

Freeciv-dev mailing list

Reply via email to