oldk1331 wrote:
>
> I have 164 commits in
>
> https://github.com/oldk1331/fricas/commits/mymaster2
>
> most of them are ready to be merged.
>
> How would you like to proceed?
I took quick look at them. Does WIP mean "Work in Progress"?
Some your changes look debatable. Obviously correct
cleanups and bug fixes can go in quickly. Some changes
I am not sure if are good: for example in one patch you
add several Lisp calls. We are trying to minimize number
of Lisp calls, so there should be really good reasons
to introduce new ones. Some patches are basically good
but they change code without adding new functionality
or fixing problems. Each change has risk of introducing
new bugs so I prefer to make such changes _after_ release.
In that way there is better chance that potential bugs
get caught before _next_ release. In fact I am putting
my changes of this sort in a queue, waiting after
release is done.
So it would be good if you could prioritise your changes.
And please for diffs (I did not see obvoius way to get
applicable diffs from Github).
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.
