On Thu, Feb 22, 2018 at 5:19 AM, Waldek Hebisch
<[email protected]> wrote:
> oldk1331 wrote:
>>
>> fix 'leaf?' in URAGG:
>>
>> https://github.com/oldk1331/fricas/commit/4aea91d7b209d856dca09569c8dc53370769f48e.patch
>
> For this we need to think about definitions. My first impulse is
> to say that leaf is node with no children, so in particular not
> empty...
Yes you are right, this is a mistake and was corrected later at:
fix 'leaf?' : empty aggregate is not a leaf because it's not a node:
https://github.com/oldk1331/fricas/commit/c13b87d54e1edbcdde871901d4ebf4ae449e6339.patch
>>
>> fix recursive 'has' expression:
>>
>> https://github.com/oldk1331/fricas/commit/fe22bec00c0cf0739dd6a9c4991af7b7eeffb7ef.patch
>
> I must admit that at first glance this one looks risky.
I discussed it in detail in September 10 2017, in a reply to mail
"DirectProduct as CancellationAbelianMonoid: subtractIfCan fails".
The code that I am modifying was written by you, where you manually
replace the top level, but I replace all levels.
>> fix documentation in aggcat.spad:
>>
>> https://github.com/oldk1331/fricas/commit/2be927aabf94ca05be45444027c12ef5172cd122.patch
>
> AFAICS '==' in original was used to get valid Spad function definition.
> I am not sure if we want to replace this by '='.
I think '==' stands for definition while '=' stands for equality, and
in documentation we should not expose implementation detail,
but expose equality properties.
> In
> setchildren! : (%, List %) -> %
> ++ setchildren!(u, v) replaces the current children of node u
> - ++ with the members of v in left-to-right order.
> + ++ with v.
>
> the orignal version is more verbose, but may be clearer than
> the shorter one.
It can't enfore left-to-right order sometimes, for exampe BinarySearchTree.
>>
>> support 'paren' and 'box' in definite integration:
>>
>> https://github.com/oldk1331/fricas/commit/a860679c40f896482ee88554cf0a8e0435f2f90b.patch
>>
>> support 'paren' and 'box' in 'limit':
>>
>> https://github.com/oldk1331/fricas/commit/1a7f813619dd0c58e42ce6a37285aca6f00d116e.patch
>>
>
> We should have some some design telling us what 'paren' and 'box'
> are supposed to do. Otherwise we risk getting mystery code
> that nobody knows what it is doing and if what it is doing
> is right or wrong.
Yes, this can be a big topic and requires more discussion.
> --
> Waldek Hebisch
>
> --
> You received this message because you are subscribed to the Google Groups
> "FriCAS - computer algebra system" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> To post to this group, send email to [email protected].
> Visit this group at https://groups.google.com/group/fricas-devel.
> For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.
