There are a couple of compile errors with this patch, so I will try to
sort those out before I get to the comments.
When I need to update the patch, do I just hg postreview -u -e 1089 -o?
I'm still new to this.
I have a small patch that fixes an Alpha compile error caused by this
patch. Should I merge that patch into this one or submit it separately,
given that the current patch is intended for ARM?
Thanks,
Erik
On 08/03/12 17:14, Ali Saidi wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1089/#review2285
-----------------------------------------------------------
src/cpu/inorder/cpu.cc
<http://reviews.gem5.org/r/1089/#comment2707>
should you still get the fault if it's a prefetch?
src/cpu/inorder/cpu.cc
<http://reviews.gem5.org/r/1089/#comment2708>
what about doing the access?
src/cpu/inorder/resources/cache_unit.cc
<http://reviews.gem5.org/r/1089/#comment2709>
probably should delete it then
- Ali Saidi
On March 8, 2012, 7:42 a.m., Korey Sewell wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1089/
-----------------------------------------------------------
(Updated March 8, 2012, 7:42 a.m.)
Review request for Default.
Description
-------
inorder: add timing translation
This is Erik Tomusk's patch to add timing translation to InOrder. It's the next
step
in getting InOrder to work for ARM.
Diffs
-----
src/cpu/inorder/cpu.hh 87cafa076695
src/cpu/inorder/cpu.cc 87cafa076695
src/cpu/inorder/resources/cache_unit.cc 87cafa076695
src/cpu/inorder/resources/inorder_translation.hh PRE-CREATION
Diff: http://reviews.gem5.org/r/1089/diff/
Testing
-------
This is not fully tested yet but a work in progress.
Thanks,
Korey Sewell
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
--
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
