> On April 3, 2012, 9:40 p.m., Gabe Black wrote: > > src/cpu/inorder/resources/cache_unit.cc, line 397 > > <http://reviews.gem5.org/r/1089/diff/5/?file=25222#file25222line397> > > > > I'm pretty sure it's not. > > Erik Tomusk wrote: > ALPHA currently does not. Don't know about the others. > > Korey Sewell wrote: > src/arch/arm/tlb.hh:208 seems to suggest that the ARM translateTiming > function returns a fault.. From a grep: > "src/arch/arm/tlb.hh:208: Fault translateTiming(RequestPtr req, > ThreadContext *tc," >
Oh, you mean the function signatures are different? That sounds like a mistake to me. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1089/#review2419 ----------------------------------------------------------- On April 4, 2012, 11:29 a.m., Korey Sewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1089/ > ----------------------------------------------------------- > > (Updated April 4, 2012, 11:29 a.m.) > > > Review request for Default. > > > Description > ------- > > inorder: add timing translation > This is Erik Tomusk's patch to add timing translation to InOrder. It's the > next step > in getting InOrder to work for ARM. > > > Diffs > ----- > > configs/common/Simulation.py 97f06a79b6f5 > src/cpu/inorder/SConscript 97f06a79b6f5 > src/cpu/inorder/cpu.hh 97f06a79b6f5 > src/cpu/inorder/cpu.cc 97f06a79b6f5 > src/cpu/inorder/inorder_dyn_inst.hh 97f06a79b6f5 > src/cpu/inorder/resources/cache_unit.hh 97f06a79b6f5 > src/cpu/inorder/resources/cache_unit.cc 97f06a79b6f5 > src/cpu/inorder/resources/fetch_unit.hh 97f06a79b6f5 > src/cpu/inorder/resources/fetch_unit.cc 97f06a79b6f5 > src/cpu/inorder/resources/graduation_unit.cc 97f06a79b6f5 > src/cpu/inorder/resources/inorder_translation.hh PRE-CREATION > src/cpu/inorder/resources/inorder_translation.cc PRE-CREATION > src/cpu/translation.hh 97f06a79b6f5 > > Diff: http://reviews.gem5.org/r/1089/diff/ > > > Testing > ------- > > This is not fully tested yet but a work in progress. > > > Thanks, > > Korey Sewell > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
