----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1089/#review2419 -----------------------------------------------------------
Just a quick pass since I didn't want to dig too much into the actual logic of the change. src/cpu/inorder/cpu.hh <http://reviews.gem5.org/r/1089/#comment2812> This should be included where it's needed, not here. I'm assuming it isn't needed here because it wasn't here before and this code compiled. src/cpu/inorder/cpu.cc <http://reviews.gem5.org/r/1089/#comment2811> This file isn't actually different. Please remove it from the change. src/cpu/inorder/resources/cache_unit.cc <http://reviews.gem5.org/r/1089/#comment2813> Unnecessary white space change. src/cpu/inorder/resources/cache_unit.cc <http://reviews.gem5.org/r/1089/#comment2817> Why is this part of the comment indented more than the earlier parts? src/cpu/inorder/resources/cache_unit.cc <http://reviews.gem5.org/r/1089/#comment2814> Don't add a bunch of commented out code. src/cpu/inorder/resources/cache_unit.cc <http://reviews.gem5.org/r/1089/#comment2816> There probably should be, but Korey is the expert and would know for sure. src/cpu/inorder/resources/cache_unit.cc <http://reviews.gem5.org/r/1089/#comment2815> I'm pretty sure it's not. src/cpu/inorder/resources/cache_unit.cc <http://reviews.gem5.org/r/1089/#comment2818> Which hack is that? src/cpu/inorder/resources/cache_unit.cc <http://reviews.gem5.org/r/1089/#comment2819> Wrong indentation. src/cpu/inorder/resources/cache_unit.cc <http://reviews.gem5.org/r/1089/#comment2820> Wrong indentation. src/cpu/inorder/resources/cache_unit.cc <http://reviews.gem5.org/r/1089/#comment2821> Bracket goes on previous line src/cpu/inorder/resources/cache_unit.cc <http://reviews.gem5.org/r/1089/#comment2822> Bracket on previous line. Fix below as well. src/cpu/inorder/resources/cache_unit.cc <http://reviews.gem5.org/r/1089/#comment2823> Fixing these random bits of trailing whitespace is good, but it should be its own change since it doesn't have anything to do with what this change is doing. src/cpu/inorder/resources/cache_unit.cc <http://reviews.gem5.org/r/1089/#comment2824> If CacheUnitEvent isn't used and shouldn't be called, get rid of it. Ideally in a separate change preceding this one. src/cpu/inorder/resources/graduation_unit.cc <http://reviews.gem5.org/r/1089/#comment2825> Bad indentation. src/cpu/inorder/resources/graduation_unit.cc <http://reviews.gem5.org/r/1089/#comment2826> Bad indentation. src/cpu/inorder/resources/inorder_translation.hh <http://reviews.gem5.org/r/1089/#comment2827> Don't comment out code, delete it. src/cpu/translation.hh <http://reviews.gem5.org/r/1089/#comment2810> The indentation here is wrong, unless review board is confused somehow. Please fix up style problems. - Gabe Black On April 1, 2012, 5:55 p.m., Korey Sewell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1089/ > ----------------------------------------------------------- > > (Updated April 1, 2012, 5:55 p.m.) > > > Review request for Default. > > > Description > ------- > > inorder: add timing translation > This is Erik Tomusk's patch to add timing translation to InOrder. It's the > next step > in getting InOrder to work for ARM. > > > Diffs > ----- > > src/cpu/inorder/resources/graduation_unit.cc 6df06e5975c6 > src/cpu/inorder/resources/inorder_translation.hh PRE-CREATION > src/cpu/translation.hh 6df06e5975c6 > src/cpu/inorder/cpu.hh 6df06e5975c6 > src/cpu/inorder/cpu.cc 6df06e5975c6 > src/cpu/inorder/inorder_dyn_inst.hh 6df06e5975c6 > src/cpu/inorder/resources/cache_unit.hh 6df06e5975c6 > src/cpu/inorder/resources/cache_unit.cc 6df06e5975c6 > > Diff: http://reviews.gem5.org/r/1089/diff/ > > > Testing > ------- > > This is not fully tested yet but a work in progress. > > > Thanks, > > Korey Sewell > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
