> On June 17, 2013, 11:39 a.m., Nilay Vaish wrote: > > src/mem/SimpleDRAM.py, line 185 > > <http://reviews.gem5.org/r/1927/diff/1/?file=36224#file36224line185> > > > > Ok, I am confused here. What is the difference between a dram page and > > a > > row buffer? It seems to me that you are assuming something more than > > what > > has been stated here as 128 * 64 != 1024. > > Amin Farmahini wrote: > as far as I know, row and page are usually used the same way. I am saying > usually, because some people tend to use differently. Andreas may correct me. > 1kB per module. since this is 8x8, so the rowbuffer is 8k per entire DRAM.
Then, mention this in that comment. I think you are missing the fact that for three types of DRAM defined, all of them have almost the same comment before bursts_per_rowbuffer is assigned. Second, since this param is being computed from other params, therefore either this should not be a param at all. Or it should be at least computed from those otehr params and not directly assigned like this. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1927/#review4440 ----------------------------------------------------------- On June 17, 2013, 4:13 a.m., Amin Farmahini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1927/ > ----------------------------------------------------------- > > (Updated June 17, 2013, 4:13 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch gets rid of bytesPerCacheLine parameter and makes the DRAM > configuration separate from cache line size. > Instead of bytesPerCacheLine, I define a parameter for DRAM called > burst_length. The burst_length parameter shows the size of a DRAM burst in > bytes and is 64 bytes for all current DRAM configurations. Note, this > parameter is coupled with tBURST. > Also, I replace lines_per_rowbuffer with bursts_per_rowbuffer, because > lines_per_rowbuffer is defined based on 64-byte cache lines which makes the > code unportable. > > Next patch could be to add support for requests larger than burst length. > > > Diffs > ----- > > src/mem/SimpleDRAM.py UNKNOWN > src/mem/simple_dram.hh UNKNOWN > src/mem/simple_dram.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/1927/diff/ > > > Testing > ------- > > None > > > Thanks, > > Amin Farmahini > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
