> On June 17, 2013, 2:58 p.m., Andreas Hansson wrote: > > src/mem/SimpleDRAM.py, line 185 > > <http://reviews.gem5.org/r/1927/diff/1/?file=36224#file36224line185> > > > > Would it not make more sense to express the row buffer as a MemorySize > > param and thus in kb/bytes? > > Amin Farmahini wrote: > yes, that's what I suggested in my email too. > the reason that I did not do that is that I did not want to divert from > your design significantly. I knew you guys will raise a lot of questions, so > I tried to stick with the original code as much as I can, so I get fewer > questions :). > Now that you want it, sure I'll do it.
Excellent. Great initiative by the way :-) - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1927/#review4441 ----------------------------------------------------------- On June 17, 2013, 4:13 a.m., Amin Farmahini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1927/ > ----------------------------------------------------------- > > (Updated June 17, 2013, 4:13 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch gets rid of bytesPerCacheLine parameter and makes the DRAM > configuration separate from cache line size. > Instead of bytesPerCacheLine, I define a parameter for DRAM called > burst_length. The burst_length parameter shows the size of a DRAM burst in > bytes and is 64 bytes for all current DRAM configurations. Note, this > parameter is coupled with tBURST. > Also, I replace lines_per_rowbuffer with bursts_per_rowbuffer, because > lines_per_rowbuffer is defined based on 64-byte cache lines which makes the > code unportable. > > Next patch could be to add support for requests larger than burst length. > > > Diffs > ----- > > src/mem/SimpleDRAM.py UNKNOWN > src/mem/simple_dram.hh UNKNOWN > src/mem/simple_dram.cc UNKNOWN > > Diff: http://reviews.gem5.org/r/1927/diff/ > > > Testing > ------- > > None > > > Thanks, > > Amin Farmahini > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
