On Nov 9, 2010, at 9:14 PM, Nathan Binkert wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/299/
>
> Love it. One thing I'd like to see would be to strip BUILD_DIR from the file
> name when printing. I can do that in a separate changeset though if you
> prefer.
Since SCons is doing the $TARGET substitution, I'm not sure how I make this
happen.
> SConstruct (Diff revision 3)
> 792
> return "Generating switch header " + str(target[0])
> 803
> return " [GN] " + str(target[0])
> I think that you should do this one the same way that you do the others with
> the getOutput function
If you look at this all I'm doing is s/ Generating switch header/[GN]/g the
verbosity of this hasn't really changed any.
> src/SConscript (Diff revision 3)
> 304
> Action(makeTheISA, *getOutput(" [IA] $TARGET")))
> perhaps it would be better to have a MakeAction() function that buries the
> *getOutput code inside and just does something like:
> def MakeAction(func, string):
> if env['VERBOSE']:
> return Action(func)
> else:
> return Action(func, string)
Maybe, but I'm 99% sure that that will change the signature of the build so
verbose and non-verbose will rebuild everything.
Ali
> - Nathan
>
>
> On November 9th, 2010, 6:59 p.m., Ali Saidi wrote:
>
> Review request for Default.
> By Ali Saidi.
> Updated 2010-11-09 18:59:43
>
> Description
>
> Scons: Try to make SCons output prettier.
>
> This change has scons print [ C], [CC], [LN], etc in front of normal commands
> instead of the entire command themselves and cleans up the build a good bit.
> Unfortunately, I couldn't figure out a way to get the same behavior from
> env.Command() calls so they're still verbose.
>
> Thoughts? Like it? Hate it?
> Diffs
>
> SConstruct (f4362ffd810f)
> src/SConscript (f4362ffd810f)
> src/arch/isa_parser.py (f4362ffd810f)
> src/cpu/SConscript (f4362ffd810f)
> View Diff
>
> _______________________________________________
> m5-dev mailing list
> [email protected]
> http://m5sim.org/mailman/listinfo/m5-dev
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
